Update k8s and other deps #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
requested review from
asuresh4,
jchengsfx,
jrcamp,
keitwb,
molner and
mstumpfx
as code owners
keitwb
reviewed
Dec 14, 2020
rmfitzpatrick
force-pushed
the
update_k8s
branch
4 times, most recently
from
5645b46
to
669ad0e
Compare
rmfitzpatrick
changed the title
rmfitzpatrick
force-pushed
the
update_k8s
branch
from
669ad0e
to
54db69a
Compare
keitwb
approved these changes
Dec 15, 2020
added 2 commits
December 15, 2020 14:18
Include vendored soheilhy/cmux that adopts go modules while breaking out example test module to relax conflicting google.golang.org/grpc/examples test dep.
rmfitzpatrick
force-pushed
the
update_k8s
branch
from
54db69a
to
cf8d1e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes attempt to add compatibility with shared Splunk OTel Collector dependencies for usage in that library.
k8s.io/*libs from 0.17.0 to 0.19.4hashicorp/consul1.4.0 tohashicorp/consul/api1.7.0hashicorp/vaultfromv1.1.1-0.20190321125746-66ef59957aafto 1.6.0signalfx/ingest-protocolsv0.0.16In order to comply with these updates a few signature changes needed to be adopted and some conflicting dependencies required some workarounds:
soheilhy/cmuxversion that adopts go modules to remove a breaking test dependency.google.golang.org/grpc v1.29.1since etcd's test dependencies cap at this version before a breaking package removal occurred. When we want to move past this version, upstream or a forked version of etcd will need updates to no longer rely ongrpc/naming.status: Investigating potential CI fallout.status: I believe I've made all the necessary changes, but will investigate the apparent perf test issues.
-- edit: I missed adding the
thirdpartydirectory to thefakek8stest service so these should be ok.